TransientSpace.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

TransientSpace.

Andrew-106
In the class TransientSpace there is a method with signature:

String read (String key);

whose comment says this is "same as Space.rd (key)".

However the implementation actually performs:

Object o = inp (key);

Which is correct: a) the comment, or b) the code?
If a) is true then then the line of code should read

Object o = rdp (key);

else if b) is true, can we fix the comment?

Sorry for the pedantry.

Cheers,
Andrew.




------------------------ Yahoo! Groups Sponsor --------------------~-->
<font face=arial size=-1><a href="http://us.ard.yahoo.com/SIG=12hebqo5f/M=362329.6886308.7839368.1510227/D=groups/S=1705006764:TM/Y=YAHOO/EXP=1122948625/A=2894321/R=0/SIG=11dvsfulr/*http://youthnoise.com/page.php?page_id=1992
">Fair play? Video games influencing politics. Click and talk back!</a>.</font>
--------------------------------------------------------------------~->

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/jpos-dev/

<*> To unsubscribe from this group, send an email to:
    [hidden email]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/
 



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TransientSpace.

Alejandro Revilla
>
> String read (String key);
>
> whose comment says this is "same as Space.rd (key)".
>
> However the implementation actually performs:
>
> Object o = inp (key);
>
> Which is correct: a) the comment, or b) the code?
> If a) is true then then the line of code should read
>
> Object o = rdp (key);
>
> else if b) is true, can we fix the comment?
>
Good catch, both are wrong :)

   The comment should say:

      * same as (String) Space.rdp (key)

   and the code should be:

       Object o = rdp (key);

We highly recommend to use the basic operations, in/inp/rd/rdp/out,
if I recall correctly, this 'String read(key)' method is there just to
be able to expose it via JMX/http-adaptor, but you don't have that
method in the Space interface.

I'm fixing them now, thanks!

>
> Sorry for the pedantry.
>
You kidding? we appreciate the report.




------------------------ Yahoo! Groups Sponsor --------------------~-->
<font face=arial size=-1><a href="http://us.ard.yahoo.com/SIG=12h1b3hj6/M=362131.6882499.7825260.1510227/D=groups/S=1705006764:TM/Y=YAHOO/EXP=1122949890/A=2889191/R=0/SIG=10r90krvo/*http://www.thebeehive.org
">Get Bzzzy! (real tools to help you find a job) Welcome to the Sweet Life - brought to you by One Economy</a>.</font>
--------------------------------------------------------------------~->

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/jpos-dev/

<*> To unsubscribe from this group, send an email to:
    [hidden email]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/
 



Loading...